Re: [PATCH v2 03/14] block: Add bio_clone_bioset()
From: Vivek Goyal <hidden>
Date: 2012-05-24 18:45:07
Also in:
dm-devel, linux-fsdevel, lkml
On Wed, May 23, 2012 at 05:02:40PM -0700, Kent Overstreet wrote: [..]
quoted hunk
--- a/drivers/md/dm.c +++ b/drivers/md/dm.c@@ -1062,26 +1062,19 @@ static struct bio *split_bvec(struct bio *bio, sector_t sector, * Creates a bio that consists of range of complete bvecs. */ static struct bio *clone_bio(struct bio *bio, sector_t sector, - unsigned short idx, unsigned short bv_count, + unsigned short bv_count, unsigned int len, struct bio_set *bs) { struct bio *clone; - clone = bio_alloc_bioset(GFP_NOIO, bio->bi_max_vecs, bs); - __bio_clone(clone, bio); + clone = bio_clone_bioset(bio, GFP_NOIO, bs); clone->bi_sector = sector; - clone->bi_idx = idx; - clone->bi_vcnt = idx + bv_count; + clone->bi_vcnt = bv_count;
In last posting you said that you are going to backout this idx change because you were not sure if it is correct. Thanks Vivek