Re: [PATCH 08/13] block: Kill bi_destructor
From: Tejun Heo <hidden>
Date: 2012-05-18 16:21:42
Also in:
dm-devel, linux-fsdevel, lkml
Hello,
quoted hunk
@@ -417,8 +409,11 @@ void bio_put(struct bio *bio) if (bio->bi_pool) bio_free(bio, bio->bi_pool); - else - bio->bi_destructor(bio); + else { + if (bio_integrity(bio)) + bio_integrity_free(bio, fs_bio_set); + kfree(bio);
if {
} else {
}
And wouldn't it be better to make bio_free() handle kfreeing too?
Overall, I really like this change. I hate how ->bi_destructor() has
been used.
Thanks!
--
tejun