On Fri, May 25, 2012 at 01:57:38PM -0700, Kent Overstreet wrote:

Right now, users of the rb tree code have to open code their own search and
insert functions. This provides generic versions that you pass a comparison
function to.

I highly doubt the extra function calls are going to have a measurable
performance impact in practice - the pointer chasing is going to dominate. I
did provide inline versions just in case, though - it's modelled after the
spinlock code.

Modeled after spinlock code how?  AFAICS, spinlock code doesn't
present inline and !inline versions to users.  All the current users
are inline anyway, why not just provide inlined versions and worry
about whether inlining is beneifical in a separate patch?

Thanks.

-- 
tejun