On Fri, May 11, 2012 at 09:29:42AM -0400, Jeff Moyer wrote:

[top posting fixed]

Kent Overstreet [off-list ref] writes:

quoted

2012/5/10 Vivek Goyal [off-list ref]:

quoted

On Wed, May 09, 2012 at 11:08:13PM -0400, Kent Overstreet wrote:

[..]

quoted

-
-     if (bio_integrity(bio)) {
-             bio_integrity_clone(clone, bio, GFP_NOIO, bs);
-
+#if 0
+     if (bio_integrity(bio))
              if (idx != bio->bi_idx || clone->bi_size < bio->bi_size)
                      bio_integrity_trim(clone,
                                         bio_sector_offset(bio, idx, 0), len);
-     }
-
+#endif

Dead/debug code under "#if 0" ?

Oh, I never got around to figuring out what needed to be done with the
bio integrity - presumably it'll have to be handled differently
somehow (I'm assuming an index in the integrity bvec is intended to
match up with an index in the regular bvec), but I don't have any way
to test the integrity stuff.

The scsi debug module supports dif/dix, so you can use that for testing.

Thanks, I'll try that.