Thread (1 message) 1 message, 1 author, 2011-09-10
DORMANTno replies

[PATCH 7/7] Don't require latency_warn_ms from bcache_util.o

From: Mark Hills <hidden>
Date: 2011-09-10 13:45:39
Subsystem: block layer, the rest · Maintainers: Jens Axboe, Linus Torvalds

When building as a module, we can't see this variable. This removes
useful debugging; probably some restructuring would be better here.

I'm not clear on the responsibilities of bcache.c, vs. bcache_util.c,
there seem to be references in both directions.
---
 block/bcache_util.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/block/bcache_util.c b/block/bcache_util.c
index b014e8c..11a81c0 100644
--- a/block/bcache_util.c
+++ b/block/bcache_util.c
@@ -378,8 +378,6 @@ void closure_put(struct closure *c, struct workqueue_struct *wq)
 	bool sleeping;
 	int r;
 again:
-	pr_latency(c->wait_time, "%pf", c->fn);
-
 	sleeping = test_bit(__CLOSURE_SLEEPING, &c->flags);
 	r = atomic_dec_return(&c->remaining);
 	smp_mb__after_atomic_dec();
-- 
1.7.4.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help