Thread (5 messages) 5 messages, 2 authors, 2026-01-20

Re: [PATCH v3 1/2] ARM: dts: aspeed: add an alt 128M flash layout

From: Marc Olberding <hidden>
Date: 2026-01-20 20:30:15
Also in: linux-arm-kernel, linux-devicetree, lkml

On Tue, Jan 20, 2026 at 08:40:29PM +0100, Krzysztof Kozlowski wrote:
On 20/01/2026 20:26, Marc Olberding wrote:
You cannot test this patch that way - DTSI is not included by anything.
This probably should be squashed with next one because makes little
benefit on its own,
Ack, will do in the next patch series.
quoted
Ran dtbs check, no errors from the msx4 dts
Drop this sentence, it's implied. There is no point to state obvious,
e.g. that you build source code, in the commit msg. It serves no purpose
in the git history. You also have changelog for such things, if you want
to emphasize.
ack, will drop.
quoted
running diff between the main and alt flash layouts shows that the only
diff is alt prepended to the partition labels, as expected.
? Not sure what you want to say, but please do not explain us how DTS
works (in case this was about DTS).
I'll drop this piece. This was a recommended piece of testing by Andrew,
the maintainer, just to show that the alt partition and main partition files
are only different by the label names. That said, its redundant with the testing
on target shown above.

Thanks for your feedback
Marc
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help