Thread (32 messages) 32 messages, 5 authors, 2025-11-05

Re: [PATCH v6 4/6] arm64: dts: aspeed: Add initial AST2700 SoC device tree

From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-10-23 18:28:41
Also in: linux-arm-kernel, linux-devicetree, lkml

quoted
quoted
+		mdio0: mdio@14040000 {
+			compatible = "aspeed,ast2600-mdio";
+			reg = <0 0x14040000 0 0x8>;
+			resets = <&syscon1 SCU1_RESET_MII>;
+			status = "disabled";
+		};
I see that you use the old compatible="aspeed,ast2600-mdio" string exclusively
here. While this works, I would suggest you list both a more specific
"aspeed,ast2700-mdio" string to refer to the version in this chip as well as the
fallback "aspeed,ast2600-mdio" string as the generic identifier.

The binding obviously has to describe both in that case, but the driver does not
need to be modified as long as both behave the same way.
Thanks, will submit ast2700-mdio. 
Question, should I add in here patch series?
Or go for another patch thread?
Please submit it to net-next. Since you will have aspeed,ast2600-mdio
as a fail back, it will work until everything meets up in linux-next.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help