Thread (2 messages) 2 messages, 2 authors, 2025-01-30

Re: [PATCH v2] drm/aspeed: Use devm_platform_get_and_ioremap_resource()

From: Andrew Jeffery <andrew@codeconstruct.com.au>
Date: 2025-01-30 05:32:14
Also in: dri-devel, linux-arm-kernel, lkml

On Wed, 2025-01-22 at 11:01 +0800, oushixiong1025@163.com wrote:
quoted hunk ↗ jump to hunk
From: Shixiong Ou <redacted>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to
devm_platform_get_and_ioremap_resource().

Signed-off-by: Shixiong Ou <redacted>
---
V1 -> V2: Add Missing commit message.

 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
index a7a6b70220eb..33f81b53771d 100644
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
@@ -146,8 +146,7 @@ static int aspeed_gfx_load(struct drm_device
*drm)
        struct resource *res;
        int ret;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       priv->base = devm_ioremap_resource(drm->dev, res);
+       priv->base = devm_platform_get_and_ioremap_resource(pdev, 0,
&res);
        if (IS_ERR(priv->base))
                return PTR_ERR(priv->base);
 
I think I prefer this one:

https://lore.kernel.org/all/20250128-cocci-memory-api-v1-1-0d1609a29587@redhat.com/ (local)

Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help