Re: [net-next 1/3] dt-bindings: net: add support for AST2700
From: Rob Herring <robh@kernel.org>
Date: 2024-11-19 18:18:33
Also in:
linux-arm-kernel, linux-devicetree, lkml, netdev
On Mon, Nov 18, 2024 at 06:47:33PM +0800, Jacky Chou wrote:
The AST2700 is the 7th generation SoC from Aspeed. Add compatible support for AST2700 in yaml.
"Add compatible..." is obvious from the diff. Add something about why the diff is how it is. For example, it is not compatible with AST2600 because...
quoted hunk
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> --- .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml index d6ef468495c5..6dadca099875 100644 --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml@@ -19,7 +19,9 @@ allOf: properties: compatible: - const: aspeed,ast2600-mdio + enum: + - aspeed,ast2600-mdio + - aspeed,ast2700-mdio reg: maxItems: 1-- 2.25.1