-----Original Message-----
From: Andrew Jeffery <andrew@codeconstruct.com.au>
Sent: Thursday, September 12, 2024 10:11 AM
To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
patrick at stwcx.xyz; Rob Herring [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Conor Dooley [off-list ref]; Joel Stanley
[off-list ref]
Cc: Ricky CX Wu <redacted>;
devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
for CPLD IOE

 [External Sender]

 [External Sender]

On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:

quoted

From: Ricky CX Wu <redacted>

We use CPLD to emulate gpio pca9506 I/O expander on each server
boards.
Therefore, add pca9506 to probe driver for the CPLD I/O expander.

I think it might be best if you add your own compatible to the list in the
gpio-pca95xx binding just in case there are some behavioural quirks of your
CPLD implementation? Not sure if this should be "facebook,pca9506" or
"wywinn,pca9506", but assuming facebook, from there you can specify

    compatible = "facebook,pca9506", "nxp,pca9506";

This allows you to add the quirks to the driver as required in the future through
the more-specific compatible.

Andrew

Hi Andrew,

Thanks for the review.
I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version of patches.