-----Original Message-----
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sent: Wednesday, December 1, 2021 2:18 PM
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew
Jeffery [off-list ref]; Cai Huoqing [off-list ref]; Tao Ren
[off-list ref]; Julia Lawall [off-list ref]; kernel test
robot [off-list ref]; Sasha Levin [off-list ref];
linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org;
linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; BMC-SW
[off-list ref]
Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

On Wed, Dec 01, 2021 at 05:43:16AM +0000, Neal Liu wrote:

quoted

quoted

-----Original Message-----
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sent: Tuesday, November 30, 2021 7:45 PM
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>;
Andrew Jeffery [off-list ref]; Cai Huoqing
[off-list ref]; Tao Ren [off-list ref]; Julia
Lawall [off-list ref]; kernel test robot [off-list ref];
Sasha Levin [off-list ref]; linux-usb at vger.kernel.org;
linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
linux-aspeed at lists.ozlabs.org; BMC-SW [off-list ref]
Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier
descriptor

On Tue, Nov 30, 2021 at 06:42:53PM +0800, Neal Liu wrote:

quoted

Support qualifier descriptor to pass USB30CV compliance test.

Please provide more information here in this description.  This does
not explain what is happening here very well.

Also, what is "USB30CV"?

USB 3 Command Verifier (USB3CV) is the official tool for USB 3 Hub and

Device Framework testing.

quoted

The USB3CV tool includes the xHCI Compliance Drivers for use with the

USB3CV.

Please put that information in the changelog text.

quoted

We would like to pass USB3CV - Chapter 9 Test [USB 2 devices] - Device

Qualifier Tests.

quoted

A high-speed capable device that has different device information for
full-speed and high-speed must have a Device Qualifier Descriptor.
This patch is to support device qualifier, and the host will retrieve it through

Get Descriptor request.

Again, this type of information needs to go into the changelog text.

thanks,

greg k-h

Okay, I'll put it in next patch. Thanks

-Neal