Thread (8 messages) 8 messages, 6 authors, 2021-10-08

[PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled

From: Joel Stanley <joel@jms.id.au>
Date: 2021-10-08 04:43:41
Also in: linux-arm-kernel, linux-media, lkml, openbmc

Hi Greg,

On Tue, 28 Sept 2021 at 18:57, Zev Weiss [off-list ref] wrote:
On Mon, Sep 06, 2021 at 04:47:14AM PDT, Joel Stanley wrote:
quoted
Hi Mauro,

On Mon, 6 Sept 2021 at 10:10, Ryan Chen [off-list ref] wrote:
quoted
quoted
Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't
enabled

On Thu, 2021-06-17 at 17:02 -0500, Zev Weiss wrote:
quoted
As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear
garbage interrupts"), the ASpeed video engine sometimes asserts
interrupts that the driver hasn't enabled.  In addition to the
CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that
patch, COMP_READY has also been observed.  Instead of playing
whack-a-mole with each one individually, we can instead just blanket
ignore everything we haven't explicitly enabled.
Suspect this will fix an intermittent problem on AST2500 with screensaver.
Change looks good, thanks!

Reviewed-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Ryan Chen <ryan_chen@aspeedtech.com>
quoted
quoted
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
I notice this wasn't merged in the pull request you sent for v5.15.
Would you be able to ensure it makes it in the next pull request you
send?

It can have some fixes tags too:

Fixes: 65d270acb2d6 ("media: aspeed: clear garbage interrupts")
Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver")
Acked-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel
Also not in the recent merge of the media/v5.15-2 tag it looks like -- ping?
We're struggling to get a hold of the media maintainers to merge this
fix. Have you heard from them recently?

Cheers,

Joel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help