[PATCH] i2c/busses:remove unneeded variable: "ret"
From: Joel Stanley <joel@jms.id.au>
Date: 2021-02-23 11:19:28
Also in:
linux-arm-kernel, linux-i2c, lkml, openbmc
On Tue, 23 Feb 2021 at 08:04, [off-list ref] wrote:
From: dingsenjie <redacted> remove unneeded variable: "ret". Signed-off-by: dingsenjie <redacted>
Thanks for the patch. Instead of removing the unused variable, I think the code could be improved to return error codes when the recovery fails. Cheers, Joel
quoted hunk ↗ jump to hunk
--- drivers/i2c/busses/i2c-aspeed.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index 724bf30..efad900 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c@@ -175,7 +175,6 @@ struct aspeed_i2c_bus { static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus) { unsigned long time_left, flags; - int ret = 0; u32 command; spin_lock_irqsave(&bus->lock, flags);@@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus) out: spin_unlock_irqrestore(&bus->lock, flags); - return ret; + return 0; reset_out: spin_unlock_irqrestore(&bus->lock, flags); --1.9.1