[PATCH, v1 1/1] gpio: aspeed: Add gpio base address reading
From: Hongwei Zhang <hidden>
Date: 2021-01-13 23:11:03
Also in:
linux-arm-kernel, linux-gpio, lkml, openbmc
Subsystem:
gpio subsystem, the rest · Maintainers:
Linus Walleij, Bartosz Golaszewski, Linus Torvalds
On Wed, Jan 13, 2021 at 11:38 PM Hongwei Zhang [off-list ref] wrote:quoted
Add gpio base address reading in the driver; in old code, it just returns -1 to gpio->chip.base. Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system") Signed-off-by: Hongwei Zhang <redacted>NAK, sorry. We never allow the device tree to specify this. First, it is a Linux-only base so it would have to be a "linux,..." property. Even if it is a Linux-only property, it is a bad idea. Only people using sysfs should have any need to specify global GPIO numbers. Don't use sysfs. Use the GPIO character device instead. See further: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpio/TODO Yours, Linus Walleij
Hi Linus, Thanks for your review and advice. --Hongwei