[PATCH 2/2] EDAC/ti: Fix handling of platform_get_irq() error
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-08-27 07:08:01
Also in:
linux-arm-kernel, linux-edac, lkml
Subsystem:
edac-core, edac-ti, the rest · Maintainers:
Borislav Petkov, Tony Luck, Tero Kristo, Linus Torvalds
platform_get_irq() returns -ERRNO on error. In such case comparison
to 0 would pass the check.
Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/edac/ti_edac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
index 6e52796a0b41..e7eae20f83d1 100644
--- a/drivers/edac/ti_edac.c
+++ b/drivers/edac/ti_edac.c@@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev) /* add EMIF ECC error handler */ error_irq = platform_get_irq(pdev, 0); - if (!error_irq) { + if (error_irq < 0) { + ret = error_irq; edac_printk(KERN_ERR, EDAC_MOD_NAME, "EMIF irq number not defined.\n"); goto err;
--
2.17.1