Thread (10 messages) 10 messages, 4 authors, 2019-08-22

[PATCH v5 1/2] dt-bindings: mmc: Document Aspeed SD controller

From: Joel Stanley <joel@jms.id.au>
Date: 2019-08-15 05:36:25
Also in: linux-arm-kernel, linux-devicetree, lkml

On Wed, 7 Aug 2019 at 00:38, Andrew Jeffery [off-list ref] wrote:
The ASPEED SD/SDIO/MMC controller exposes two slots implementing the
SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit
data bus if only a single slot is enabled.

Signed-off-by: Andrew Jeffery <redacted>
Reviewed-by: Joel Stanley <joel@jms.id.au>

Two minor comments below.
quoted hunk ↗ jump to hunk
+++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
No "Copyright IBM" ?
+%YAML 1.2
+---
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    sdc at 1e740000 {
+            compatible = "aspeed,ast2500-sd-controller";
+            reg = <0x1e740000 0x100>;
+            #address-cells = <1>;
+            #size-cells = <1>;
+            ranges = <0 0x1e740000 0x10000>;
According to the datasheet this could be 0x20000. It does not matter
though, as there's nothing in it past 0x300.

Cheers,

Joel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help