Re: [RFC] drm/msm/dp: Allow attaching a drm_panel
From: Doug Anderson <dianders@chromium.org>
Date: 2021-08-27 20:52:27
Also in:
dri-devel, lkml
From: Doug Anderson <dianders@chromium.org>
Date: 2021-08-27 20:52:27
Also in:
dri-devel, lkml
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson [off-list ref] wrote:
+static int dp_parser_find_panel(struct dp_parser *parser)
+{
+ struct device_node *np = parser->pdev->dev.of_node;
+ int rc;
+
+ rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL);Why port 2? Shouldn't this just be port 1 always? The yaml says that port 1 is "Output endpoint of the controller". We should just use port 1 here, right? -Doug