Re: [PATCH v2 4/5] drm/msm/dp: Store each subblock in the io region

From
Stephen Boyd <hidden>
Date
2021-08-26 01:21:56
Also in
dri-devel, linux-devicetree, lkml
Reply to
Bjorn Andersson, 2021-08-25
Quoting Bjorn Andersson (2021-08-25 15:25:56)
Not all platforms has DP_P0 at offset 0x1000 from the beginning of the
DP block. So split the dss_io_data memory region into a set of
sub-regions, to make it possible in the next patch to specify each of
the sub-regions individually.

Signed-off-by: Bjorn Andersson <redacted>
---
One nit below:

Reviewed-by: Stephen Boyd <redacted>

quoted hunk ↗ jump to hunk
diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h b/drivers/gpu/drm/msm/dp/dp_parser.h
index dc62e70b1640..a95b05dbb11c 100644
--- a/drivers/gpu/drm/msm/dp/dp_parser.h
+++ b/drivers/gpu/drm/msm/dp/dp_parser.h
@@ -25,9 +25,16 @@ enum dp_pm_type {
        DP_MAX_PM
 };

-struct dss_io_data {
-       size_t len;
+struct dss_io_region {
        void __iomem *base;
+       size_t len;
It flip flops here. Would be nice to the diff if len was where it really
wanted to be.
quoted hunk ↗ jump to hunk
+};
+
+struct dss_io_data {
+       struct dss_io_region ahb;
+       struct dss_io_region aux;
+       struct dss_io_region link;
+       struct dss_io_region p0;
 };
Thread (8 messages) 8 messages, 2 authors, last reply 2021-08-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help