Hi Philipp,
On Wed, 2026-11-11 at 10:49 +0100, Philipp Zabel wrote:
Is the i2c-mt7621 driver actually used with any reset controller that
implements .reset but not .assert/.deassert?
No. Its users are MT7621 and MT7628 (clk-mtmips, which implements
assert, deassert and reset) and EN7581/AN7589 (this driver, assert and
deassert only).
If not, it would be better to let i2c-mt7621 use
reset_control_assert/deassert() instead of adding .reset ops to all
reset controller drivers it is used with.
Agreed. I will drop this patch from v2 and change i2c-mt7621 to assert
and deassert the line instead. That patch goes into v2 of my
"i2c: mt7621: add Airoha AN7589 support" series.
Is having no delay here valid for all possible reset consumers or are
we implicitly assuming that this will only ever be used for specific
i2c resets?
Only for the I2C block, which is a further reason to keep the
sequence in the I2C driver.
Thanks,
John