Re: [PATCH v2] soc: qcom: apr: Reject packets with header size larger than packet size

From
Abel Vesa <hidden>
Date
2026-11-05 08:52:16
Also in
linux-arm-msm, linux-sound, lkml, stable
Reply to
Krzysztof Kozlowski, 2026-11-01
On 26-11-01 20:07:35, Krzysztof Kozlowski wrote:
apr_do_rx_callback() and gpr_do_rx_callback() validate the header size
and the packet size separately, but never check that the header fits
within the packet.  Both sizes are u16, so with a malformed packet where
the header size exceeds the packet size, the subtraction computing
resp.payload_size gets promoted to int and becomes negative.

Further check "resp.payload_size > 0" would fail, leading to
resp.payload left uninitialized (stack value).  Reject such packets as
having a wrong packet size, although unlikely that firmware would
produce such packets.

Fixes: 6adba21eb434 ("soc: qcom: Add APR bus driver")
Fixes: ec1471a898cc ("soc: qcom: apr: Add GPR support")
Cc: <redacted>
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/bug/linux-82d40745-1593-4c20-8432-d86099836525
Signed-off-by: Krzysztof Kozlowski <redacted>
Reviewed-by: Abel Vesa <redacted>
Thread (6 messages) 6 messages, 4 authors, last reply 12d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help