On 26-11-01 20:07:35, Krzysztof Kozlowski wrote:
apr_do_rx_callback() and gpr_do_rx_callback() validate the header size
and the packet size separately, but never check that the header fits
within the packet. Both sizes are u16, so with a malformed packet where
the header size exceeds the packet size, the subtraction computing
resp.payload_size gets promoted to int and becomes negative.
Further check "resp.payload_size > 0" would fail, leading to
resp.payload left uninitialized (stack value). Reject such packets as
having a wrong packet size, although unlikely that firmware would
produce such packets.
Fixes: 6adba21eb434 ("soc: qcom: Add APR bus driver")
Fixes: ec1471a898cc ("soc: qcom: apr: Add GPR support")
Cc: <redacted>
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/bug/linux-82d40745-1593-4c20-8432-d86099836525
Signed-off-by: Krzysztof Kozlowski <redacted>
Reviewed-by: Abel Vesa <redacted>