Re: [PATCH 00/12] irqchip: validate remaining MADT records before use

From
Marc Zyngier <maz@kernel.org>
Date
2026-10-28 08:23:22
Also in
linux-mips, linux-riscv, lkml, loongarch
Reply to
Jiale Yao, 2026-10-28
On Wed, 28 Oct 2026 05:00:27 +0000,
Jiale Yao [off-list ref] wrote:
Several ACPI interrupt-controller callbacks cast generic MADT subtable
headers to controller-specific records and access typed fields without
first checking that the firmware supplied the complete structure. A
truncated entry can therefore cause an out-of-bounds read during early
interrupt-controller and CPU discovery.

Add the missing minimum-size checks at the callback boundaries. Records
which are passed from a probe validator to an initialization callback are
validated once in the validator, before either callback accesses them.

The issues were found by code inspection and have not been tested on real
hardware.
How does this compare to the series posted at [1]?

No version number, no change log, and not even an attempt at a QEMU
test run. If you want people to review this stuff, you need to up your
game a tiny bit.

	M.

[1] https://lore.kernel.org/20261021144524.364143-1-yaojiale02@163.com (local)

-- 
Without deviation from the norm, progress is not possible.
Thread (6 messages) 6 messages, 2 authors, last reply 21d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help