Re: [PATCH net] net: stmmac: unwind the WoL IRQ after a safety IRQ request failure

Hi James

On 1.10.2026 06:31, James Hilliard wrote:

The safety IRQ is requested after the MAC and optional WoL IRQs. If its
request fails, stmmac_free_irq() frees the unregistered safety IRQ and
leaks the WoL handler. This can warn about an already-free IRQ and make
the next open fail.

Move the safety and WoL cleanup labels into reverse acquisition order.
This also fixes unwind after later per-queue IRQ request failures.

Does it? AFAIU those cases already fell through both the WoL and safety
free_irq() calls before? Only the free order changes, which makes
REQ_IRQ_ERR_SFTY the only broken case?

[...]

With that sentence above dropped or reworded:

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks,
Nicolai