Re: [PATCH net-next v10 03/11] phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-10-05 20:59:41
Also in:
linux-devicetree, linux-phy, linux-renesas-soc, linux-rockchip, lkml, netdev
On Wed, 23 Sep 2026 04:03:27 +0800 Coia Prant wrote:
On RK3568, the SGMII interface can be routed to either GMAC0 or
GMAC1 via the GRF register pipe_sgmii_mac_sel.
Add support for this selection by introducing
the "rockchip,sgmii-mac-sel" DT property.
From the RK3568 TRM (Part1, Page 229), the PIPE_GRF_XPCS_CON0
bit 1 (pipe_sgmii_mac_sel) is defined as:
0: SGMII routed to GMAC0
1: SGMII routed to GMAC1
The hardware reset value is 1 (GMAC1). If the property is set to 0,
the driver routes SGMII to GMAC0; if set to 1 (or omitted), it
remains at GMAC1.
This is necessary for boards such as the Ariaboard Photonicat, which
uses the SGMII interface connected to GMAC0.
Out-of-range values are rejected by dtschema, so the driver does not
duplicate the range check.While looking thru the patches again I noticed this is changing generic PHY. Maybe you can send it separately to Vinod? I don't see a hard dependency? The code can "converge" during the merge window for the whole thing to work.