[PATCH net-next v2 0/2] net: stmmac: Report RSS as not supported
WARM2d
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2026-09-28 14:51:12
Also in:
lkml, netdev
Hi everyone, This is V2 of an RSS cleanup for stmmac, discovered while running the rss kselftests on stmmac. It returns bogus indirection tables and key sizes, when RSS isn't actually available at all. RSS is currently not supported on any stmmac devices upstream, so code that was already useless is now effectively dead. It has been the case since 2019 when the code was added, as platforms need to set rss_en in their plat data, and no glue ever did that. Russell King ran a poll in february 2026 [1] asking if the code should be dropped, without any reply going in either direction. Jitendra Vegiraju from Broadcom sent 9 iterations of a Broadcom PCIe glue driver [2] that actually sets rss_en = 1, so there's some hope that this may be used in the future. [1]: https://lore.kernel.org/netdev/aYd4BkAeNW6d0iIC@shell.armlinux.org.uk/ (local) [2]: https://lore.kernel.org/netdev/20260402213629.1996133-1-jitendra.vegiraju@broadcom.com/ (local) Nvidia platforms seem to be RSS capable, but it's not going to work out of the box. Let's leave the feature there for now, with proper -EOPNOTSUPP returned for RSS ops. V2: - target net-next - Add a dedicated helper, following Nicolai's review. V1: https://lore.kernel.org/netdev/20260926093343.292181-1-maxime.chevallier@bootlin.com/#t (local) Maxime Chevallier (2): net: stmmac: Introduce a helper to check RSS support net: stmmac: Don't set or get RSS parameters when not supported drivers/net/ethernet/stmicro/stmmac/stmmac.h | 5 +++++ drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 12 ++++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 3 files changed, 19 insertions(+), 2 deletions(-) -- 2.55.0