[PATCH v7 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print
flat view
COLD16d
From: Daniel Golle <daniel@makrotopia.org>
Date: 2026-09-24 18:41:16
Also in:
dri-devel, linux-mediatek, lkml
Subsystem:
drm drivers, drm drivers and misc gpu patches, drm drivers for bridge chips, the rest · Maintainers:
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Andrzej Hajda, Neil Armstrong, Robert Foss, Linus Torvalds
REG_AUDIO_INPUT_FREQ reads back 0 when no audio clock has been
latched, and it6505_read() returns a negative errno on i2c failure.
The debug print divides by the readback, and its arguments are
evaluated even with debug output disabled. Only print when the value
is usable as a divisor.
Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v7: no changes
v6: no changes
v5: new patch
---
drivers/gpu/drm/bridge/ite-it6505.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 180a270ecfc1..0e7dbc119a05 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c@@ -1623,8 +1623,11 @@ static void it6505_enable_audio(struct it6505 *it6505) it6505_set_bits(it6505, REG_AUDIO_SRC_CTRL, AUDIO_FIFO_RESET, 0x00); it6505_set_bits(it6505, REG_RESET_CTRL, AUDIO_RESET, 0x00); regbe = it6505_read(it6505, REG_AUDIO_INPUT_FREQ); - DRM_DEV_DEBUG_DRIVER(dev, "regbe:0x%02x audio input fs: %d.%d kHz", - regbe, 6750 / regbe, (6750 % regbe) * 10 / regbe); + if (regbe > 0) + DRM_DEV_DEBUG_DRIVER(dev, + "regbe:0x%02x audio input fs: %d.%d kHz", + regbe, 6750 / regbe, + (6750 % regbe) * 10 / regbe); it6505_set_bits(it6505, REG_DATA_MUTE_CTRL, EN_AUD_MUTE, 0x00); }
--
2.55.0