Thread (59 messages) 59 messages, 8 authors, 10d ago

[PATCH v19 5/7] firmware: arm_rmm: Activate the RMM

flat view
COOLING10d REVIEWED: 2 (0M)

From: Suzuki K Poulose <suzuki.poulose@arm.com>
Date: 2026-09-24 13:52:37
Also in: kvm, kvmarm, linux-coco, lkml
Subsystem: the rest · Maintainer: Linus Torvalds

Revision v19 of 6 in this series; 2 review trailers.

Revisions (6)
  1. v17 [diff vs current]
  2. v18 [diff vs current]
  3. v19 current
  4. v20 [diff vs current]
  5. v21 [diff vs current]
  6. v22 [diff vs current]
From: Steven Price <steven.price@arm.com>

Activate the RMM after the basic configuration. This is a memory
transferring stateful operation.

Reviewed-by: Gavin Shan <redacted>
Reviewed-by: Jonathan Cameron <redacted>
Signed-off-by: Steven Price <steven.price@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
Changes since v17:
 * Inline RMM_ACTIVATE command and remove the definitions from arm-rmi-cmds.h
 * Use scope-based cleanup to free sro object
Changes since v16:
 * Split into a new patch
---
 drivers/firmware/arm_rmm/rmi.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_rmm/rmi.c b/drivers/firmware/arm_rmm/rmi.c
index 035f21d3f26b6..0859f256e192b 100644
--- a/drivers/firmware/arm_rmm/rmi.c
+++ b/drivers/firmware/arm_rmm/rmi.c
@@ -834,7 +834,18 @@ static int __init arm64_init_rmi(void)
 	if (ret)
 		return ret;
 
-	return 0;
+	/* Activate the RMM */
+	struct rmi_sro_state *sro __free(kfree) = kmalloc_obj(*sro);
+	if (!sro)
+		return -ENOMEM;
+
+	ret = rmi_sro_memxfer_cmd(sro, GFP_KERNEL, SMC_RMI_RMM_ACTIVATE);
+	if (ret) {
+		pr_err("RMM activate failed (%d)\n", ret);
+		ret = ret < 0 ? ret : -ENXIO;
+	}
+
+	return ret;
 }
 
 /*
-- 
2.43.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help