[PATCH v5 03/12] ufs: unipro: Add TX/RX FSM state attributes
flat view
COLD22d
SUPERSEDED: 13 (13M)
From: Larisa Grigore <hidden>
Date: 2026-09-22 07:33:33
Also in:
imx, linux-arm-msm, linux-devicetree, linux-scsi, lkml
Subsystem:
arm/qualcomm mailing list, scsi subsystem, the rest, universal flash storage host controller driver, universal flash storage host controller driver amd versal2, universal flash storage host controller driver dwc hooks, universal flash storage host controller driver qualcomm hooks · Maintainers:
"James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds, Sai Krishna Potthuri, Ajay Neeli, Pedro Sousa, Manivannan Sadhasivam
Revision v5 of 8 in this series; 1 review trailer.
Revisions (8)
Add TX_FSM_STATE and RX_FSM_STATE to include/ufs/unipro.h, as these are UniPro M-PHY attribute definitions rather than host controller specific ones. Remove the duplicated local definitions from the HiSilicon, Qualcomm, AMD Versal and DesignWare UFS headers. This also prepares for using these definitions in a subsequent commit. Signed-off-by: Larisa Grigore <redacted> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- drivers/ufs/host/ufs-amd-versal2.c | 4 ++-- drivers/ufs/host/ufs-hisi.c | 8 ++++---- drivers/ufs/host/ufs-hisi.h | 5 ----- drivers/ufs/host/ufs-qcom.c | 4 ++-- drivers/ufs/host/ufs-qcom.h | 1 - drivers/ufs/host/ufshcd-dwc.h | 4 ---- include/ufs/unipro.h | 2 ++ 7 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/ufs/host/ufs-amd-versal2.c b/drivers/ufs/host/ufs-amd-versal2.c
index 2154d6286817..0d4d5e98ad65 100644
--- a/drivers/ufs/host/ufs-amd-versal2.c
+++ b/drivers/ufs/host/ufs-amd-versal2.c@@ -112,7 +112,7 @@ static int ufs_versal2_enable_phy(struct ufs_hba *hba) u32 time_left, mibsel; time_left = TIMEOUT_MICROSEC; - mibsel = UIC_ARG_MIB_SEL(MTX_FSM_STATE, UIC_ARG_MPHY_TX_GEN_SEL_INDEX(offset)); + mibsel = UIC_ARG_MIB_SEL(TX_FSM_STATE, UIC_ARG_MPHY_TX_GEN_SEL_INDEX(offset)); do { ret = ufshcd_dme_get(hba, mibsel, ®); if (ret)
@@ -132,7 +132,7 @@ static int ufs_versal2_enable_phy(struct ufs_hba *hba) } time_left = TIMEOUT_MICROSEC; - mibsel = UIC_ARG_MIB_SEL(MRX_FSM_STATE, UIC_ARG_MPHY_RX_GEN_SEL_INDEX(offset)); + mibsel = UIC_ARG_MIB_SEL(RX_FSM_STATE, UIC_ARG_MPHY_RX_GEN_SEL_INDEX(offset)); do { ret = ufshcd_dme_get(hba, mibsel, ®); if (ret)
diff --git a/drivers/ufs/host/ufs-hisi.c b/drivers/ufs/host/ufs-hisi.c
index 2d214ce9620e..bd223bda1ce2 100644
--- a/drivers/ufs/host/ufs-hisi.c
+++ b/drivers/ufs/host/ufs-hisi.c@@ -30,10 +30,10 @@ static int ufs_hisi_check_hibern8(struct ufs_hba *hba) unsigned long timeout = jiffies + msecs_to_jiffies(HBRN8_POLL_TOUT_MS); do { - err = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE, 0), + err = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(TX_FSM_STATE, 0), &tx_fsm_val_0); err |= ufshcd_dme_get(hba, - UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE, 1), &tx_fsm_val_1); + UIC_ARG_MIB_SEL(TX_FSM_STATE, 1), &tx_fsm_val_1); if (err || (tx_fsm_val_0 == TX_STATE_HIBERN8 && tx_fsm_val_1 == TX_STATE_HIBERN8)) break;
@@ -47,10 +47,10 @@ static int ufs_hisi_check_hibern8(struct ufs_hba *hba) * check the state again. */ if (time_after(jiffies, timeout)) { - err = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE, 0), + err = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(TX_FSM_STATE, 0), &tx_fsm_val_0); err |= ufshcd_dme_get(hba, - UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE, 1), &tx_fsm_val_1); + UIC_ARG_MIB_SEL(TX_FSM_STATE, 1), &tx_fsm_val_1); } if (err) {
diff --git a/drivers/ufs/host/ufs-hisi.h b/drivers/ufs/host/ufs-hisi.h
index 6af6a268458d..08dccfbec404 100644
--- a/drivers/ufs/host/ufs-hisi.h
+++ b/drivers/ufs/host/ufs-hisi.h@@ -39,11 +39,6 @@ #define MASK_UFS_DEVICE_RESET (0x1 << 16) #define BIT_UFS_DEVICE_RESET (0x1) -/* - * M-TX Configuration Attributes for Hixxxx - */ -#define MPHY_TX_FSM_STATE 0x41 - /* * Hixxxx UFS HC specific Registers */
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 38897d01fde2..1e492dac8d93 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c@@ -390,7 +390,7 @@ static int ufs_qcom_check_hibern8(struct ufs_hba *hba) do { err = ufshcd_dme_get(hba, - UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE, + UIC_ARG_MIB_SEL(TX_FSM_STATE, UIC_ARG_MPHY_TX_GEN_SEL_INDEX(0)), &tx_fsm_val); if (err || tx_fsm_val == TX_STATE_HIBERN8)
@@ -406,7 +406,7 @@ static int ufs_qcom_check_hibern8(struct ufs_hba *hba) */ if (time_after(jiffies, timeout)) err = ufshcd_dme_get(hba, - UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE, + UIC_ARG_MIB_SEL(TX_FSM_STATE, UIC_ARG_MPHY_TX_GEN_SEL_INDEX(0)), &tx_fsm_val);
diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h
index 3c6cb2281af0..1ec661277c1d 100644
--- a/drivers/ufs/host/ufs-qcom.h
+++ b/drivers/ufs/host/ufs-qcom.h@@ -10,7 +10,6 @@ #include <soc/qcom/ice.h> #include <ufs/ufshcd.h> -#define MPHY_TX_FSM_STATE 0x41 #define HBRN8_POLL_TOUT_MS 100 #define DEFAULT_CLK_RATE_HZ 1000000 #define MAX_SUPP_MAC 64
diff --git a/drivers/ufs/host/ufshcd-dwc.h b/drivers/ufs/host/ufshcd-dwc.h
index a5e40e7604a1..0406f2bb576b 100644
--- a/drivers/ufs/host/ufshcd-dwc.h
+++ b/drivers/ufs/host/ufshcd-dwc.h@@ -27,10 +27,6 @@ #define CBREFREFCLK_GATE_OVR_EN BIT(7) -/* M-PHY Attributes */ -#define MTX_FSM_STATE 0x41 -#define MRX_FSM_STATE 0xC1 - /* M-PHY registers */ #define RX_OVRD_IN_1(n) (0x3006 + ((n) * 0x100)) #define RX_PCS_OUT(n) (0x300F + ((n) * 0x100))
diff --git a/include/ufs/unipro.h b/include/ufs/unipro.h
index e0f490e11c7f..6fee545bdee5 100644
--- a/include/ufs/unipro.h
+++ b/include/ufs/unipro.h@@ -34,6 +34,7 @@ #define TX_PWM_G6_G7_SYNC_LENGTH 0x0034 #define TX_HS_DEEMPHASIS_SETTING 0x0037 #define TX_HS_PRESHOOT_SETTING 0x003B +#define TX_FSM_STATE 0x0041 #define TX_REFCLKFREQ 0x00EB #define TX_CFGCLKFREQVAL 0x00EC #define CFGEXTRATTR 0x00F0
@@ -72,6 +73,7 @@ #define CFGRXCDR8 0x00BA #define CFGRXOVR8 0x00BD #define CFGRXOVR6 0x00BF +#define RX_FSM_STATE 0x00C1 #define RX_FOM 0x00C2 #define RXDIRECTCTRL2 0x00C7 #define CFGRXOVR4 0x00E9
--
2.43.0