Thread (47 messages) 47 messages, 9 authors, 2026-09-23

Re:Re: [PATCH v7 09/15] gpiolib: regmap: add gpio_regmap_get_chip()

flat view

From: zl020895 <hidden>
Date: 2026-09-22 04:23:41
Also in: linux-clk, linux-devicetree, linux-gpio, linux-serial, lkml

Hi Michael,

Thanks for the review.

gpio-regmap can already attach a domain via config.irq_domain or
regmap_irq_chip. PL061 cannot use regmap-irq: type is programmed in
IS/IBE/IEV (including both-edge) and the parent IRQ is an AMBA chained
demux.

In v8 the custom linear domain used the gpio_chip as host_data, and
that chip only exists after gpio_regmap_register(), so I added
gpio_regmap_get_chip().

I can drop the helper: create the domain with the PL061 private data as
host_data, pass it in config.irq_domain, and let gpio-regmap register
it. I will do that in the next revision if you agree.

Best regards,
Long Zhao

At 2026-09-21 20:48:44, "Michael Walle" [off-list ref] wrote:
On Tue Sep 15, 2026 at 1:15 PM CEST, Long Zhao via B4 Relay wrote:
quoted
From: Long Zhao <redacted>

Let drivers that implement a custom irqchip retrieve the gpio_chip
after registration. Attach a caller-provided irq_domain only when it
is present.
So why do we need this? Why can't gpio-regmap register the
irq_domain?

-michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help