[PATCH net 0/3] net: stmmac: fix failed MTU reopening and hardware resume
From: James Hilliard <hidden>
Date: 2026-09-21 16:54:05
Also in:
lkml, netdev
A failed stmmac MTU-change reopen leaves the netdev administratively up after its replacement DMA resources have been freed. A later close can repeat NAPI shutdown and IRQ or DMA-resource teardown. A failed hardware resume similarly leaves an up interface with NAPI already disabled, so closing it can hang in a second napi_disable(). Fix these error paths by tracking whether the data path is open and closing the netdev through the network core after failed reinitialization. For failed resume, release the suspended data path without disabling NAPI again. Allow phylink to finish shutdown directly from its suspended state without restarting a MAC whose hardware setup has failed. Signed-off-by: James Hilliard <redacted> --- These fixes were previously posted as patches 1-3 of the H616 EMAC1 v4 series. Split them into a separate net series as requested by Maxime Chevallier. The sun8i MAC-reset change, EMAC1 binding and variant remain in the net-next series. Changes since that posting: - Adapt the failed-resume fix to the net tree's older stmmac_resume() implementation, leaving timestamping behavior unchanged. - Add a Fixes tag for the phylink suspend/stop handling. Previous posting: https://patch.msgid.link/20260920-submit-h616-emac1-v1-v4-0-8347dfe2eb7d@gmail.com To: Russell King <linux@armlinux.org.uk> To: Andrew Lunn <andrew@lunn.ch> To: Heiner Kallweit <hkallweit1@gmail.com> To: "David S. Miller" <davem@davemloft.net> To: Eric Dumazet <edumazet@google.com> To: Jakub Kicinski <kuba@kernel.org> To: Paolo Abeni <pabeni@redhat.com> To: Joakim Zhang <redacted> To: "Russell King (Oracle)" <redacted> To: Maxime Chevallier <maxime.chevallier@bootlin.com> To: Andrew Lunn <andrew+netdev@lunn.ch> To: Maxime Coquelin <mcoquelin.stm32@gmail.com> To: Alexandre Torgue <alexandre.torgue@foss.st.com> To: Christian Marangi <ansuelsmth@gmail.com> To: Tiezhu Yang <yangtiezhu@loongson.cn> To: Huacai Chen <chenhuacai@kernel.org> Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- James Hilliard (3): net: phylink: allow stopping a suspended instance net: stmmac: close the interface after a failed MTU reopen net: stmmac: close the interface after failed hardware resume drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 39 ++++++++++++++++++----- drivers/net/phy/phylink.c | 16 ++++++++++ 3 files changed, 49 insertions(+), 8 deletions(-) --- base-commit: 1e24c4f2ee44be0eee94092b5d13cbdb4bdf0d60 change-id: 20260921-submit-stmmac-reset-fixes-v1-7c98b92d29a9 Best regards, -- James Hilliard [off-list ref]