Re: [PATCH 3/3] pmdomain: imx93-blk-ctrl: Use pm_runtime_resume_and_get()
From: Frank Li <hidden>
Date: 2026-09-21 16:19:00
Also in:
imx, linux-pm, lkml
On Mon, Sep 21, 2026 at 10:37:08AM +0700, phucduc.bui@gmail.com wrote:
From: bui duc phuc <redacted> Replace the open-coded pm_runtime_get_sync() + pm_runtime_put_noidle() error handling pattern with pm_runtime_resume_and_get(), which already does this internally. No functional change. Found by manual code inspection. Signed-off-by: bui duc phuc <redacted> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
quoted hunk ↗ jump to hunk
drivers/pmdomain/imx/imx93-blk-ctrl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/pmdomain/imx/imx93-blk-ctrl.c b/drivers/pmdomain/imx/imx93-blk-ctrl.c index 243ce939ba68..6d4c55a85c64 100644 --- a/drivers/pmdomain/imx/imx93-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx93-blk-ctrl.c@@ -152,9 +152,8 @@ static int imx93_blk_ctrl_power_on(struct generic_pm_domain *genpd) return ret; } - ret = pm_runtime_get_sync(bc->dev); + ret = pm_runtime_resume_and_get(bc->dev); if (ret < 0) { - pm_runtime_put_noidle(bc->dev); dev_err(bc->dev, "failed to power up domain\n"); goto disable_clk; } --2.43.0