Thread (2 messages) 2 messages, 2 authors, 12d ago

Re: [PATCH] mailbox: mtk-cmdq: Fix GCE clock reference leak in cmdq_get_clocks()

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2026-09-17 12:06:22
Also in: linux-mediatek, lkml, stable

On Thu, Sep 17, 2026 at 09:37:45AM +0000, Wentao Liang wrote:
of_clk_get() returns the clock with an elevated reference count, but
the references taken for the other GCE clocks are never dropped: those
clocks outlive probe and the driver calls neither clk_put() nor
clk_bulk_put(), so probing a GCE with multiple instances leaks one
reference per other GCE clock.

Let devres drop the references when the device goes away, which also
covers the probe failure paths after cmdq_get_clocks() has returned.

Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for mt8195")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <redacted>
Please stop sending these patches.  You are not responding to any
feedback, so we are assuming you are just a bot :(

All should be dropped until proven otherwise.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help