Re: [PATCH v4 03/20] dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-09-17 06:54:13
Also in:
dri-devel, linux-clk, linux-devicetree, linux-phy, linux-riscv, linux-rockchip, lkml
On Tue, Sep 15, 2026 at 05:32:11PM +0200, Michal Wilczynski wrote:
Add the dt-binding for the StarFive JH7110 HDMI subsystem.
Your cover letter, in the first paragraph, should explain the merging/dependencies constraints - this depends on previous patches and cannot be taken alone.
quoted hunk ↗ jump to hunk
The JH7110 HDMI IP is a monolithic block containing both the digital controller and analog PHY in a single register space. This binding defines the parent device, which holds the shared register map and populates its two children: the PHY and the controller. This is necessary to resolve a circular clock dependency between the HDMI block and the VOUT clock generator. Reviewed-by: Joshua Peisach <redacted> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- .../mfd/starfive,jh7110-hdmi-subsystem.yaml | 95 ++++++++++++++++++++++ 1 file changed, 95 insertions(+)diff --git a/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem.yaml b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem.yaml new file mode 100644 index 0000000000000000000000000000000000000000..18034d8273b860b71d386cfc63a125f21b20a6b1 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsystem.yaml@@ -0,0 +1,95 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/starfive,jh7110-hdmi-subsystem.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: StarFive JH7110 HDMI subsystem + +maintainers: + - Michal Wilczynski <m.wilczynski@samsung.com> + +description: + The StarFive JH7110 HDMI block is a monolithic IP containing both + the digital controller logic and the analog PHY logic in a single + register space. It sits inside the video output subsystem, which owns + the NoC bus clock and reset gating this region and the power domain it + belongs to. + +properties: + compatible: + const: starfive,jh7110-hdmi-subsystem + + reg: + maxItems: 1 + + phy: + $ref: /schemas/phy/starfive,jh7110-inno-hdmi-phy.yaml# + + controller: + $ref: /schemas/display/bridge/starfive,jh7110-inno-hdmi-controller.yaml#
This node is just too empty... but let's discuss this in the phy patch, where I already commented. Best regards, Krzysztof