Re: [PATCH v3 00/12] ASoC: mediatek: mt8189: Improve error handling

On 9/16/26 07:00, phucduc.bui@gmail.com wrote:

From: bui duc phuc <redacted>

Hi all,

This series addresses part of the error handling in the MT8189 AFE driver.

It propagates errors from clock operations and runtime resume, validates
clock parameters, and removes redundant error messages.

In v2, there was discussion about checking the return value of
regmap_update_bits(). While opinions differed, the existing driver already
checks it in mt8189_afe_enable_top_cg(), which is used by
mt8189_apll1_enable() and mt8189_apll2_enable() touched by this series.

Therefore, I keep these checks and add the corresponding error paths for
consistency.

Compile-tested only.

Series is

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Cheers,
Angelo

Link v1 :
https://lore.kernel.org/all/20260910125742.150902-1-phucduc.bui@gmail.com/ (local)
Link v2:
https://lore.kernel.org/all/20260914072842.24420-1-phucduc.bui@gmail.com/ (local)

Changes in v2:
  - Update the names of the goto labels.
  - Check for zero frequency since freq is unsigned.
Changes in v3:
  - Add Angelo's Reviewed-by tag.
  - Restore the existing afe->regmap checks,
    making the separate patch for missing regmap unnecessary.
  - Do not pre-initialize ret; set ret = 0 in the default case throughout
    the series.

Best regards,
Phuc

bui duc phuc (12):
   ASoC: mediatek: mt8189: Propagate APLL enable errors
   ASoC: mediatek: mt8189: Propagate MCK enable errors
   ASoC: mediatek: mt8189: Validate MCK ID
   ASoC: mediatek: mt8189: Propagate reg_rw clock errors
   ASoC: mediatek: mt8189: Use dev_err_probe() for clock errors
   ASoC: mediatek: mt8189: Propagate runtime resume errors
   ASoC: mediatek: mt8189: Remove redundant error message
   ASoC: mediatek: mt8189: Propagate APLL errors
   ASoC: mediatek: mt8189: Propagate MCLK errors
   ASoC: mediatek: mt8189: Validate sysclk frequency
   ASoC: mediatek: mt8189: Propagate TDM clock errors
   ASoC: mediatek: mt8189: Validate TDM MCLK frequency

  sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 134 +++++++++++++++------
  sound/soc/mediatek/mt8189/mt8189-afe-pcm.c |  45 ++++---
  sound/soc/mediatek/mt8189/mt8189-dai-i2s.c |  18 ++-
  sound/soc/mediatek/mt8189/mt8189-dai-tdm.c |  19 ++-
  4 files changed, 154 insertions(+), 62 deletions(-)