Thread (5 messages) 5 messages, 2 authors, 2026-09-11

Re: [PATCH 1/2] ASoC: mediatek: common: Propagate control and DAPM errors

flat view

From: Mark Brown <broonie@kernel.org>
Date: 2026-09-10 17:23:42
Also in: linux-mediatek, linux-sound, lkml

On Thu, Sep 10, 2026 at 06:43:37PM +0700, phucduc.bui@gmail.com wrote:
From: bui duc phuc <redacted>

mtk_afe_add_sub_dai_control() currently ignores errors from
ASoC control and DAPM setup functions.

Propagate these errors to the caller.
mt8365-afe-pcm.c has:

    {"HW_GAIN1_IN_CH1", "CONNSYS_I2S_CH1", "Hostless FM DL"},

missing a Switch from the control.  I suspect there's other errors; this
really needs to be tested before it can be applied.  Given the general
quality of the driver here and the lack of anything constructive we're
doing with the errors changes like this have high risk and low reward
unless we're actually running the code.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help