Thread (6 messages) flat view 6 messages, 3 authors, 9d ago

Re: [PATCH] KVM: arm64: Fix kvm_get_vtcr() kernel-doc

From: Karl Mehltretter <hidden>
Date: 2026-09-10 02:54:55
Also in: kvmarm, lkml

On Wed, Sep 09, 2026 at 08:36:40AM +0100, Fuad Tabba wrote:
Hi Karl,
While you're on that line, the description is also inaccurate, so you
could fix both in one go and save a follow-up touching the same line:
quoted
- * @phys_shfit:        Value to set in VTCR_EL2.T0SZ.
+ * @phys_shift:        Value to set in VTCR_EL2.T0SZ.
kvm_get_vtcr() sets T0SZ to 64 - phys_shift, so phys_shift isn't the
value written to the field, it's the IPA size in bits. Something like:

     * @phys_shift:    IPA size, in bits.
Hi Fuad. 

well spotted. A typo seldom comes alone :)

I'll fix that.

Thanks,
Karl
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help