Re: [PATCH v3 2/6] iio: adc: bcm_iproc_adc: fix include dependencies
From: Jonathan Cameron <jic23@kernel.org>
Date: 2026-09-05 23:34:11
Also in:
linux-iio, lkml
quoted hunk ↗ jump to hunk
Add the headers required directly by the driver for the APIs and types it uses. Remove the unused linux/io.h header now that register access is handled through regmap APIs. Signed-off-by: Mohammad Shahid <redacted>diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index e46e3761993a..e54f613d266a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c@@ -2,15 +2,18 @@ /* * Copyright 2016 Broadcom */ -
Really trivial but this change doesn't belong in here. I don't really mind whether or not there is a blank line here but it is definitely not related to the header changes that this patch is focussed on. I might fix up whilst applying or decide I can't be bothered. If you should spin a new version for other reasons please put the line back again!
+#include <linux/array_size.h> +#include <linux/bits.h> #include <linux/clk.h> +#include <linux/completion.h> #include <linux/delay.h> #include <linux/interrupt.h> -#include <linux/io.h> #include <linux/mfd/syscon.h> #include <linux/module.h> +#include <linux/mutex.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/types.h> #include <linux/iio/iio.h>
Otherwise, this looks fine to me. The sashiko comment is a preexisting issue so out of scope for this patch at least (I also didn't check if it is correct or not) Thanks, J -- Jonathan Cameron [off-list ref]