Re: [PATCH v8 07/16] usb: core: Move struct usb_port and related APIs to port.h
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-09-05 08:19:43
Also in:
driver-core, linux-acpi, linux-devicetree, linux-mediatek, linux-pm, linux-usb, lkml
On Fri, Sep 04, 2026 at 07:52:37PM +0200, Greg Kroah-Hartman wrote:
On Sat, Sep 05, 2026 at 01:24:20AM +0800, Chen-Yu Tsai wrote:quoted
On Sat, Sep 5, 2026 at 12:47 AM Greg Kroah-Hartman [off-list ref] wrote:quoted
On Fri, Sep 04, 2026 at 04:41:46PM +0800, Chen-Yu Tsai wrote:quoted
|struct usb_port| and its matching container_of() macro should live in its own port.h, matching the split we have for .c files.Why?This was requested by Andy. And to me it sort of made sense.quoted
quoted
Move them as described. Also move usb_port_is_power_on(), since in the next change its |struct usb_hub *| parameter will be changed to |struct usb_port *|, and becomes a non-static function that only references |struct usb_port|.No, please don't do that unless you have a really good reason.Which part? Move the code?Please don't make a new .h file. Moving the function might make sense on its own if you need it in a different file later on, but do a move only, and then change things if you really need to do that.
Isn't this file to break possible circular dependencies? -- With Best Regards, Andy Shevchenko