Re: [PATCH v6 11/13] serial: 8250_dw: add Ambarella CV75 quirks

From
Linus Walleij <linusw@kernel.org>
Date
2026-09-04 22:43:27
Also in
linux-clk, linux-devicetree, linux-gpio, linux-serial, lkml
Reply to
Long Zhao, 2026-09-04
On Fri, Sep 4, 2026 at 8:39 AM Long Zhao via B4 Relay
[off-list ref] wrote:
From: Long Zhao <redacted>

The Ambarella CV75 UART is Ambarella IP, not a Synopsys DesignWare
licensed block. At the register level it is close enough to DW APB UART
that a full custom UART driver is unnecessary: reuse 8250_dw with a
small platform quirk.

Quirks:
- keep IER ETOI (bit 5) set for RX timeout behaviour
- skip set_rate; baud clock is managed outside the UART block

Signed-off-by: Long Zhao <redacted>
This is really nice. Compare the size of this to what was initially
submitted!

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij
Thread (46 messages) 46 messages, 8 authors, last reply 2026-09-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help