Re: [PATCH 6/6] arm64: dts: apple: Add minimal MacBook Neo device tree

Hi,


On 04.09.26 21:49, Yureka Lilian wrote:

Added a device tree for the MacBook Neo, which uses the t8140 SoC
(A18 Pro) also found in the iPhone 16 Pro.

The device tree has a minimal set of devices limited to CPU cores,
interrupt controller, watchdog, serial and framebuffer.

Using the macOS 26.6.2 iBoot/firmware, the machine reliably boots
on a single core using the stock kernel.
Booting with smp requires avoiding the wfi and wfit instructions
in the idle loop and `delay()` respectively, since those instructions
cause a loss of architectural state on the secondary cores.

Signed-off-by: Yureka Lilian <redacted>

[...]

+
+	memory@800000000 {

this doesn't fit the reg you use below.

+		device_type = "memory";
+		reg = <0x100 0 0x2 0>; /* To be filled by loader */
+	};

[....]

+
+		aic: interrupt-controller@301000000 {
+			compatible = "apple,t8140-aic3", "apple,t8122-aic3";
+			#interrupt-cells = <3>;
+			interrupt-controller;
+			reg = <0x00000003 0x01000000 0x00000000 0x1cc000>,
+			      <0x00000003 0x01040000 0x00000000 0x4000>;

please be consistent and use 0x3 and 0x0 here like for the rest.



Sven