Thread (24 messages) flat view 24 messages, 4 authors, 15d ago

Re: [PATCH v7 1/3] mm: make persistent huge zero folio read-only

From: Mike Rapoport <rppt@kernel.org>
Date: 2026-09-03 09:21:09
Also in: linux-mm, lkml

Hi Dave,

On Wed, Sep 02, 2026 at 01:59:15PM -0700, Dave Hansen wrote:
On 9/1/26 08:18, Xueyuan Chen wrote:
quoted
+static inline int set_direct_map_ro(struct page *page, unsigned int nr)
+{
+	return 0;
+}
I still really think the stub here needs to return an error *or* the
thing needs to just be void and tell folks that they can't know whether
it worked or not.
All other stubs return 0 here when an arch does not support set_direct_map.
I'm for keeping them all consistent and fixing that technical debt as a
whole rather than creating a one-off here.

-- 
Sincerely yours,
Mike.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help