Re: [PATCH v3 3/5] ASoC: mediatek: mt8183: Fix APLL enable error handling
From: Cezary Rojewski <cezary.rojewski@intel.com>
Date: 2026-08-31 09:46:21
Also in:
linux-mediatek, linux-sound, lkml
On 8/28/2026 7:05 AM, phucduc.bui@gmail.com wrote:
From: bui duc phuc <redacted>
Currently, the mt8183_apll*_enable() functions call mux_setting(afe, true)
but do not check its return value to handle failures.
In addition, the cleanup paths of mt8183_apll*_enable() do not call
mux_setting(afe, false) when the enable operation fails, while the
mt8183_apll*_disable() functions do.
Add error handling for apll*_mux_setting() and call mux_setting(afe, false)
in the cleanup paths when mt8183_apll*_enable() fails.
Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver")
Signed-off-by: bui duc phuc <redacted>Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>