Re: [PATCH 3/3] i2c: qcom-geni: release DMA channels on probe error
flat view
From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
Date: 2026-08-31 08:52:07
Also in:
imx, linux-arm-msm, linux-i2c, lkml, stable
On 8/27/2026 9:13 PM, Shengzhuo Wei wrote:
geni_i2c_init() grabs exclusive GPI tx/rx DMA channels when the serial
engine runs in GPI mode. If i2c_add_adapter() subsequently fails, probe
returns without releasing the channels, because the remove callback is
not invoked after a failed probe.
The adapter-registration failure path used to release the channels via
its err_dma label; that release was dropped when the probe tail was
restructured into geni_i2c_init().
Release the channels on the adapter-registration failure path, mirroring
geni_i2c_remove().
Fixes: d8d3bb127ad1 ("i2c: qcom-geni: Isolate serial engine setup")
Cc: stable@vger.kernel.org
Signed-off-by: Shengzhuo Wei <redacted>
Assisted-by: GLM:5.3
---Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>