Re: [PATCH v4] ARM: imx: Fix suspend/resume crash with Clang CFI

On 2026-08-28 10:50 PM, Sami Tolvanen wrote:

Looks reasonable, but this still feels ARM-specific to me. How about
adding the macro to arch/arm/include/asm/linkage.h unless you have
other users in mind?

I've now sent a v5 with Nick's macro added to
arch/arm/include/asm/linkage.h as you suggested, plus the other fixes
Nick asked for:

https://lore.kernel.org/all/20260830155100.1020620-1-linux@yoavmoshe.com/ (local)

The sashiko-bot's comment on v5 indeed pointed out that imx5, at91 and
omap1 might suffer from the same bug: their suspend routines are also
fncpy()'d into SRAM without a type hash and called indirectly. They're
all ARM, so asm/linkage.h still seems like the right place for the
macro.

Do you think these need to be fixed as part of this patch, or as
follow-ups? I only have my one imx6 device (a Kobo Clara HD), so I'm not
sure how to test the fixes for the others.

Yo'av