Re: [PATCH v3 1/8] dt-bindings: reset: Add mt6589 toprgu reset IDs

On 12/08/2026 12:35, Krzysztof Kozlowski wrote:

On Tue, Aug 11, 2026 at 04:20:11PM +0200, Luca Leonardo Scorcia wrote:

quoted

quoted

We do not take bits, but identifiers of resets.

Currently the existing mtk_wdt.c driver does not use a reset table
that binds identifiers to bits for any of the existing devices. There
are a bunch of mediatek,mt*.h files under dt-bindings/reset [3] that
point directly to reset bits instead of being indexes.

Many got accepted unnoticed, many times we did not care, but the point
is still valid - pure hardware numbers do not belong to the bindings,
because they do not bind any pieces of code. The proper binding header
constants bind DTS with SW implementation, so two pieces of code. Not
applicable here.

quoted

I can introduce a reset table in the driver, but it would break
existing devices as those bits are referred in device trees and they
are often non-contiguous (e.g. [4]). As before, it could be done by

Then these bits stay as is in DTS but bindings header is not needed. You
can have of course DTS header, as we did in the past multiple times for
such hardware constants.

So I wrote above this to myself and can be ignored completely? Then why
would we not ignore your patches?

Best regards,
Krzysztof