Re: [PATCH v9 01/12] iommu/arm-smmu-v3: Refactor arm_smmu_setup_irqs

[ ... 84 lines skipped ... ]
+	/* Setup interrupt handlers */
+	ret = arm_smmu_setup_irqs(smmu);
+	if (ret) {
+		dev_err(smmu->dev, "failed to setup irqs\n");
+		return ret;
+	}
+

The sashiko remark makes sense to me, we should not enable interrupts
until everything has been initialized and things are ready to go. So
this is better done after the device reset call, which is the thing
that is setting up the queue pointers in HW..

I'm not sure what to make of the MSI register ordering around kdump
comment.. Nicolin?

But the refactoing looks fine to me

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

-- 
Jason