Thread (35 messages) flat view 35 messages, 3 authors, 11d ago

Re: [PATCH v9 09/12] iommu/arm-smmu-v3-kdump: Implement is_attach_deferred()

From: Nicolin Chen <hidden>
Date: 2026-08-22 20:27:28
Also in: linux-iommu, lkml

On Sat, Aug 22, 2026 at 05:02:26PM -0300, Jason Gunthorpe wrote:
On Sat, Aug 22, 2026 at 11:16:35AM -0700, Nicolin Chen wrote:
quoted
On Fri, Aug 21, 2026 at 08:15:26PM -0300, Jason Gunthorpe wrote:
quoted
quoted
@@ -1276,6 +1292,12 @@ arm_smmu_kdump_adopt_deferred_l2_strtab(struct arm_smmu_device *smmu, u32 sid,
 {
 	return -EOPNOTSUPP;
 }
+
+static inline bool
+arm_smmu_kdump_is_attach_deferred(struct arm_smmu_master *master)
+{
+	return false;
+}

?
This is for !CONFIG_CRASH_DUMP case. I think we need it.
Hmm, I am testing b4 review.. I had written

#define arm_smmu_kdump_is_attach_deferred NULL
Hmm, I'm adding two-level is_attach_deferred functions:

arm_smmu_is_attached_deferred()
{
	if (OPT_KDUMP_ADOPT)
		arm_smmu_kdump_is_attach_deferred();
		// internally doesn't check OPT_KDUMP_ADOPT  	
}
[...]
	.is_attach_deferred = arm_smmu_is_attached_deferred,

So, arm_smmu_kdump_is_attach_deferred cannot be NULL.

Nicolin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help