Re: [PATCH 06/25] ARM: dts: rockchip: Add Ethernet GMAC node for RV1106
From: Simon Glass <sjg@chromium.org>
Date: 2026-08-20 11:47:56
Also in:
linux-clk, linux-devicetree, linux-rockchip, lkml
Hi Vladislav, On Mon, 10 Aug 2026 at 06:15, Vladislav Leonov [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Rockchip RV1106 has GMAC 10/100 ethernet controller. Signed-off-by: Vladislav Leonov <redacted> --- arch/arm/boot/dts/rockchip/rv1106.dtsi | 62 ++++++++++++++++++++++++++ 1 file changed, 62 insertions(+)diff --git a/arch/arm/boot/dts/rockchip/rv1106.dtsi b/arch/arm/boot/dts/rockchip/rv1106.dtsi index fa5d0d7f4dcb..71dd3dcc386c 100644 --- a/arch/arm/boot/dts/rockchip/rv1106.dtsi +++ b/arch/arm/boot/dts/rockchip/rv1106.dtsi@@ -19,6 +19,7 @@ / { interrupt-parent = <&gic>; aliases { + ethernet0 = &gmac; gpio0 = &gpio0; gpio1 = &gpio1; gpio2 = &gpio2;@@ -282,6 +283,67 @@ system_sram: sram@ff6c0000 { ranges = <0 0xff6c0000 0x40000>; }; + gmac: ethernet@ffa80000 { + compatible = "rockchip,rv1106-gmac", "snps,dwmac-4.20a"; + reg = <0xffa80000 0x10000>; + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq", "eth_wake_irq"; + rockchip,grf = <&grf>; + clocks = <&cru CLK_GMAC0_TX_50M_O>, <&cru CLK_GMAC0_REF_50M>, + <&cru ACLK_MAC>, <&cru PCLK_MAC>;
Should this have a minItems exception like RK3506 and 3528? As it is it fails validation for me as it expects 5 clocks.
+ clock-names = "stmmaceth", "clk_mac_ref",
+ "aclk_mac", "pclk_mac";
+ resets = <&cru SRST_A_MAC>;
+ reset-names = "stmmaceth";
+
+ snps,mixed-burst;
+ snps,tso;
+
+ snps,axi-config = <&stmmac_axi_setup>;
+ snps,mtl-rx-config = <&mtl_rx_setup>;
+ snps,mtl-tx-config = <&mtl_tx_setup>;
+
+ phy-mode = "rmii";
+ clock_in_out = "input";
+ phy-handle = <&rmii_phy>;
+
+ status = "disabled";
+
+ mdio: mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+ rmii_phy: ethernet-phy@2 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <2>;
+ clocks = <&cru CLK_MACPHY>;
+ resets = <&cru SRST_MACPHY>;
+ phy-is-integrated;
+ };
+ };
+
+ stmmac_axi_setup: stmmac-axi-config {
+ snps,wr_osr_lmt = <4>;
+ snps,rd_osr_lmt = <8>;
+ snps,blen = <0 0 0 0 16 8 4>;
+ };
+
+ mtl_rx_setup: rx-queues-config {
+ snps,rx-queues-to-use = <1>;
+ queue0 {
+ status = "okay";
+ };
+ };
+
+ mtl_tx_setup: tx-queues-config {
+ snps,tx-queues-to-use = <1>;
+ queue0 {
+ status = "okay";
+ };
+ };
+ };
+
emmc: mmc@ffa90000 {
compatible = "rockchip,rv1106-dw-mshc", "rockchip,rk3288-dw-mshc";
reg = <0xffa90000 0x4000>;
--
2.47.3Regards, Simon