Re: [PATCH v2] firmware: arm_scmi: pm: use DEFINE_SIMPLE_DEV_PM_OPS for pm struct

On Thu, Aug 20, 2026 at 10:17:18AM +0800, Li Jun wrote:

use DEFINE_SIMPLE_DEV_PM_OPS for scmi_dev_pm_ops,and add the value of
.freeze .thaw .poweroff .restore.if these address are null, may cause
error in s4.

Change:
-Replace SIMPLE_DEV_PM_OPS() in v1 with DEFINE_SIMPLE_DEV_PM_OPS() for pm.

Signed-off-by: Li Jun <redacted>

The things I wrote at
https://lore.kernel.org/all/aoaFlNcXC8zfS0j5@monoceros/ (local) mostly apply
here, too.

TL;DR: Wrong placement of inter-revision changelog, missing
pm_sleep_ptr(), and maybe most prominently the request for patience to
start with a single patch and learn from the feedback for later patches.

Best regards
Uwe