Re: [PATCH 5/7] media: verisilicon: Add Rockchip VPU720 JPEG decoder

Hi,

On 2026-08-19 14:46, Heiko Stübner wrote:

Hi,

quoted

+static int vdpu720_fill_chroma(struct hantro_ctx *ctx,
+			       struct vb2_v4l2_buffer *dst_buf)

[...]

quoted

+/**
+ * rockchip_vpu720_jpeg_dec_init() - allocate the per-context DMA side buffer
+ * @ctx:	context to allocate the Q/Huffman table buffer for
+ *
+ * Return: 0 on success, -ENOMEM if the buffer could not be allocated.
+ */

again comment style ( "/**", also the ctx line could use a blank line above it)
Seemingly one function before this the LLM did get it right?

It's not as inconsistent as it seems. The exported functions have a
kerneldoc header with /** and the arguments described, the static
functions just have a freestyle header. Documentation/doc-guide/kernel-doc.rst
also doesn't have a blank line between the function name and the first
argument.

I could change the static function to kerneldoc as well if you prefer
that.

Sascha

--
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |