Thread (23 messages) flat view 23 messages, 5 authors, 25d ago

Re: [PATCH v8 10/12] accel/rocket: add RK3576 NPU (RKNN) support

From: Uwe Kleine-König <hidden>
Date: 2026-08-18 08:59:12
Also in: dri-devel, linux-devicetree, linux-iommu, linux-pm, linux-rockchip, lkml

Hello,

On Mon, Aug 17, 2026 at 11:36:01PM +1200, Jiaxing Hu wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/accel/rocket/rocket_drv.h b/drivers/accel/rocket/rocket_drv.h
index 2c673bb99..0096c4ab1 100644
--- a/drivers/accel/rocket/rocket_drv.h
+++ b/drivers/accel/rocket/rocket_drv.h
@@ -6,10 +6,12 @@
 
 #include <drm/drm_mm.h>
 #include <drm/gpu_scheduler.h>
+#include <linux/mod_devicetable.h>
Please don't use <linux/mod_devicetable.h> but <linux/device-id/of.h>.

The former is a mixture of many subsystem specifics and thus a
dependency-hog.

Best regards
Uwe

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help